Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL)
will never return.
Signed-off-by: Christophe Fergeau <cferg...@redhat.com>
---
common/log.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/common/log.h b/common/log.h
index 7c67e7a..1482358 100644
--- a/common/log.h
+++ b/common/log.h
@@ -20,6 +20,7 @@
#include <stdarg.h>
#include <stdio.h>
+#include <stdlib.h>
#include <glib.h>
#include <spice/macros.h>
@@ -42,6 +43,7 @@ void spice_log(GLogLevelFlags log_level,
#define spice_return_if_fail(x) G_STMT_START { \
if G_LIKELY(x) { } else { \
spice_log(G_LOG_LEVEL_CRITICAL, SPICE_STRLOC, G_STRFUNC, "condition
`%s' failed", #x); \
+ abort();
\
return; \
} \
} G_STMT_END
@@ -49,6 +51,7 @@ void spice_log(GLogLevelFlags log_level,
#define spice_return_val_if_fail(x, val) G_STMT_START { \
if G_LIKELY(x) { } else { \
spice_log(G_LOG_LEVEL_CRITICAL, SPICE_STRLOC, __FUNCTION__, "condition
`%s' failed", #x); \
+ abort();
\
return (val); \
} \
} G_STMT_END
@@ -71,10 +74,12 @@ void spice_log(GLogLevelFlags log_level,
#define spice_critical(format, ...) G_STMT_START { \
spice_log(G_LOG_LEVEL_CRITICAL, SPICE_STRLOC, __FUNCTION__, "" format, ##
__VA_ARGS__); \
+ abort();
\
} G_STMT_END
#define spice_error(format, ...) G_STMT_START { \
spice_log(G_LOG_LEVEL_ERROR, SPICE_STRLOC, __FUNCTION__, "" format, ##
__VA_ARGS__); \
+ abort();
\
} G_STMT_END
#define spice_warn_if_fail(x) G_STMT_START { \
--
2.21.0
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
