Il giorno mar 19 apr 2022 alle ore 11:42 Victor Toso <victort...@redhat.com> ha scritto:
> Hi, > > On Wed, Apr 13, 2022 at 03:06:24PM +0800, Walter Mitty wrote: > > Hello, > > I am learning spice-server source code. And i'm confusing the 2 > > functions in `video-stream.cpp`: video_stream_trace_update / > > video_stream_maintenance. > > > > There is a todo about it. > > Any suggestions please? > > I think the TODO is also to clarify if and when functions were > needed and how to properly use them. I'd need to dive into it to > check. If you understand them, I'd appreciate if you submit a > documentation patch about it, I'd be happy to review your > findings. > > Cheers, > Victor > Hi, I wish I had a better reply but not much. >From a quick glance one is more "focused", the other less. video_stream_trace_update is scanning all possible streams and traces looking for matches while video_stream_maintenance is looking for a single stream. Looking at callers one of the callers of video_stream_maintenance is current_add_equal which is called if another Drawable matches exactly (same position and size). Frediano
