the conditional should be changed to be against a regular variable like "__should_log_info", such as which is used in mapper. the point of the conditional everywhere is to avoid creating the string concatentations, method call overhead, and repr() calls if logging is turned off. however the current conditoinal is still ultimately calling getLogger().getEffectiveLevel() which is still a little expensive.
On Jan 25, 2:34 pm, "Jonathan Ellis" <[EMAIL PROTECTED]> wrote: > Minor question: wouldn't it be more consistent to either apply echo to > all pool logging, or get rid of it and let logger settings control it? > Here's a patch for the former. > > pool.patch > 1KDownload --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To post to this group, send email to sqlalchemy@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlalchemy?hl=en -~----------~----~----~----~------~----~------~--~---
