Michael Bayer wrote: > committed, r2409. > > the "row" needs to have a "class" and "entity_name" present to determine > what mapper you want to use to extract from the row, so i put those as > keyword arguments for now. > > also, I notice the usage of plain old "assert" for argument checking. > should we make this change across the board and get rid of > exceptions.ArgumentError ? i feel like we have to go one way or the > other with that.
Ahh, I had forgotten about ArgumentError (I have not been browsing the source much lately). I think exceptions are generally better, assert was just quick and easy. > > also i didnt do any testing of this, we might want to add some tests to > test/orm/session.py . Yeah, I guess that would be a good idea. I'll try to make a patch sometime soon. ~ Daniel --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To post to this group, send email to sqlalchemy@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlalchemy?hl=en -~----------~----~----~----~------~----~------~--~---
