On Mar 4, 2008, at 7:27 PM, Phillip J. Eby wrote:
> > Okay, so I did a matching uninstrument_attribute and > pre_uninstrument_attribute, which look like really dumb names at this > point. I propose the following name changes (in addition to the ones > in my previous patch): > > pre_instrument_attribute -> install_descriptor > pre_uninstrument_attribute -> uninstall_descriptor > > That okay? instrument_attribute will then call install_descriptor to > do the actual installing. And of course the hooks on the adapted > thingy from the class would work the same way. > > If that's okay with you, then after I'm done I'll post a patch for > review before checkin. After that, I'll start work on the > Trellis-side support for this, and then eventually dig into > collections stuff. hey phillip - It all sounds great to me ! I think its been established in the past several months that my names are generally pretty bad so I usually defer to others at this point. - mike --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To post to this group, send email to sqlalchemy@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlalchemy?hl=en -~----------~----~----~----~------~----~------~--~---
