-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi.

I find this code (sqlalchemy.dialects.postgresql.base) suspicious:

class ENUM(sqltypes.Enum):

    def create(self, bind=None, checkfirst=True):
        if not checkfirst or not bind.dialect.has_type(bind, self.name,
schema=self.schema):
            bind.execute(CreateEnumType(self))

    def drop(self, bind=None, checkfirst=True):
        if not checkfirst or bind.dialect.has_type(bind, self.name,
schema=self.schema):
            bind.execute(DropEnumType(self))


The code does not handle the case when bind is None.

However, looking at sqlalchemy.types.SchemaType, bind is never None.

In the SchemaType docstring there is a typo: "complimented" should be
"complemented".


Manlio
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkuMB3EACgkQscQJ24LbaUSSJwCgh/WpOlqHqz9Cex7ZxFcIH3ZZ
B+AAn1aCQEYtsA/ctE90uDWHGtlg42Fy
=vQq7
-----END PGP SIGNATURE-----

-- 
You received this message because you are subscribed to the Google Groups 
"sqlalchemy" group.
To post to this group, send email to sqlalch...@googlegroups.com.
To unsubscribe from this group, send email to 
sqlalchemy+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sqlalchemy?hl=en.

Reply via email to