> -----Original Message----- > From: sqlalchemy@googlegroups.com > [mailto:sqlalch...@googlegroups.com] On Behalf Of Michael Bayer > Sent: 04 June 2010 14:42 > To: sqlalchemy@googlegroups.com > Subject: Re: [sqlalchemy] SA on MySQL 3.23 > > > On Jun 4, 2010, at 6:54 AM, King Simon-NFHD78 wrote: > > > > I'll happily try any suggestions you've got :-) > > I couldn't see anything in the MySQL docs that > suggested an alternative > to the CAST function, so it seems reasonable to just > omit it for older > MySQL servers. I applied the attached patch, and it at > least allowed me > to connect to the server and issue basic queries, but I > haven't done any > more testing than that. > > Option 1 sounded best to me just because I didn't know > if there would be > any other places that SA might implicitly run a query > that included a > CAST. I suppose it changes the semantics of the query though... > > I've tried to run the unit tests, but I get lots of > errors and failures > that I assume are expected on such an old version of MySQL. > > > > its not entirely my usual style to have an operator emit > nothing on a given platform instead of failing, but because > this is such an old MySQL version and "cast" is a little bit > of a crossover operator it isn't bothering me much here. I > can commit your patch with an extra "artificial" compiler > test in dialect/test_mysql.py to ensure it does what's > expected; if you want to tool around with it a bit this week, > let me know that we're good with it. > >
If you're more comfortable with a version that just doesn't call _check_unicode_returns, or that catches the exception, either would be fine with me. I just sent the first thing I tried that seemed to work. I agree that silently converting CAST to nothing might mask other bugs, and so probably isn't ideal. Which would be your preference then? Catching the exception, or not calling the method in the first place? I'll make a patch for whichever you prefer and test it next week. Thanks again, Simon -- You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To post to this group, send email to sqlalch...@googlegroups.com. To unsubscribe from this group, send email to sqlalchemy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sqlalchemy?hl=en.
