if you want to make a simple pull request that just adds a keyword argument “comments” to Column and Table (including some basic tests, probably in test/sql/test_compiler.py for now), we can add that in. The more elaborate stuff with __doc__ and declarative, I definitely don’t think __doc__ and SQL-level comments should be linked together unconditionally. At most for that, for people who really want that, I’d offer some recipe or if it’s more complicated, then an extension.
the other side of SQL comments is of course reflection of those comments. That would need work too. then it can even impact migrations and alembic! so, this starts small but can go on and on :). > On Oct 27, 2014, at 2:21 PM, Jacek Szpot <malig...@gmail.com> wrote: > > Hey list, > > What's the state of support for column comments? I was only able to dig out > one mention of this — from 2009 [1] — and the docs only seem to mention this > in the description of the `Column.doc` attribute. [2] > > I'd be interested in helping out with this one, if possible. Just let me know > what's the story so far. > > [1] https://bitbucket.org/zzzeek/sqlalchemy/issue/1546 > [2] > http://docs.sqlalchemy.org/en/latest/core/metadata.html#sqlalchemy.schema.Column.params.doc > > -- > You received this message because you are subscribed to the Google Groups > "sqlalchemy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sqlalchemy+unsubscr...@googlegroups.com > <mailto:sqlalchemy+unsubscr...@googlegroups.com>. > To post to this group, send email to sqlalchemy@googlegroups.com > <mailto:sqlalchemy@googlegroups.com>. > Visit this group at http://groups.google.com/group/sqlalchemy > <http://groups.google.com/group/sqlalchemy>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sqlalchemy+unsubscr...@googlegroups.com. To post to this group, send email to sqlalchemy@googlegroups.com. Visit this group at http://groups.google.com/group/sqlalchemy. For more options, visit https://groups.google.com/d/optout.
