Hi All,

Since 1.1.0 was released yesterday, one of my library's nightly builds have started failing:

https://travis-ci.org/Mortar/mortar_mixins/jobs/165422873

Error was:

AssertionError: CompileError(u"Column 'model.period' is marked as a member of the primary key for table 'model', but has no Python-side or server-side default generator indicated, nor does it indicate 'autoincrement=True' or 'nullable=True', and no explicit value is passed. Primary key columns typically may not store NULL. Note that as of SQLAlchemy 1.1, 'autoincrement=True' must be indicated explicitly for composite (e.g. multicolumn) primary keys if AUTO_INCREMENT/SERIAL/IDENTITY behavior is expected for one of the columns in the primary key. CREATE TABLE statements are impacted by this change as well on most backends.",) raised, <class 'sqlalchemy.exc.IntegrityError'> expected

The test is here:

https://github.com/Mortar/mortar_mixins/blob/master/tests/test_temporal.py#L268

So, this code path used to previously raise an IntegrityError and now raises a CompileError. What was the driver for that? I can certainly see there being code in the wild that was expecting an IntegrityError and will now fail...

(I guess I also have a niggle that this feels like SQLAlchemy is doing more work than it was before, will this have performance implications?)

Chris

--
You received this message because you are subscribed to the Google Groups 
"sqlalchemy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sqlalchemy+unsubscr...@googlegroups.com.
To post to this group, send email to sqlalchemy@googlegroups.com.
Visit this group at https://groups.google.com/group/sqlalchemy.
For more options, visit https://groups.google.com/d/optout.

Reply via email to