On Wed, Oct 18, 2017 at 10:18 AM, Gijs Molenaar <gijsmolen...@gmail.com> wrote: > Hi again! > > This is the hopefully the last mail since this is the last failing test for > the MonetDB dialect! > > I noticed that some tests in the CompoundSelectTest class do a select() on > the union: > > https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/testing/suite/test_select.py#L298 > > While others don't, for example: > > https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/testing/suite/test_select.py#L283 > > MonetDB is having a bit of problems processing unions without a enclosing > select statement. > > So question again is, is this a mistake in the test, or should the MonetDB > dialect be smart enough to handle this?
without the enclosing select, that test generates this: SELECT DISTINCT some_table.id, some_table.x, some_table.y FROM some_table WHERE some_table.id = ? UNION SELECT DISTINCT some_table.id, some_table.x, some_table.y FROM some_table WHERE some_table.id = ? ORDER BY id LIMIT ? OFFSET ? that's standard SQL that all current tested databases can handle, yes. If MonetDB cannot, there can be a requirements rule to establish this or you can have these tests skipped by overriding them in your own test suite per the technique shown in README.dialects.rst. > > related issues: > > https://github.com/gijzelaerr/sqlalchemy-monetdb/issues/16 > https://github.com/gijzelaerr/sqlalchemy-monetdb/issues/15 > > -- > SQLAlchemy - > The Python SQL Toolkit and Object Relational Mapper > > http://www.sqlalchemy.org/ > > To post example code, please provide an MCVE: Minimal, Complete, and > Verifiable Example. See http://stackoverflow.com/help/mcve for a full > description. > --- > You received this message because you are subscribed to the Google Groups > "sqlalchemy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sqlalchemy+unsubscr...@googlegroups.com. > To post to this group, send email to sqlalchemy@googlegroups.com. > Visit this group at https://groups.google.com/group/sqlalchemy. > For more options, visit https://groups.google.com/d/optout. -- SQLAlchemy - The Python SQL Toolkit and Object Relational Mapper http://www.sqlalchemy.org/ To post example code, please provide an MCVE: Minimal, Complete, and Verifiable Example. See http://stackoverflow.com/help/mcve for a full description. --- You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sqlalchemy+unsubscr...@googlegroups.com. To post to this group, send email to sqlalchemy@googlegroups.com. Visit this group at https://groups.google.com/group/sqlalchemy. For more options, visit https://groups.google.com/d/optout.
