On Wed, Feb 13, 2008 at 11:42 PM, Jason R. Coombs <[EMAIL PROTECTED]> wrote: > > I've run into a project that demands Python 2.3 (they've got a large > codebase that's still running on Python 2.3) and I'll be implementing > some features in that application that utilize Elixir (if possible). > > I see that some patches are in the trunk of SQLAlchemy that support > Python 2.3, but Elixir still has trouble in some cases. > > I'm going to file a bug to this effect and I have a patch that fixes > the two issues I've encountered through my own code. > > There are still 11 tests that fail under Python 2.3 that fall into 4 > categories (list sort parameter, @beforeinsert decorator, generator > comprehension, and a Crypto lib issue). Of course, more issues may > emerge after the tests are fixed. > > Questions > Can my patch be integrated into the trunk?
Sure. I've now committed a modified version of your patch. Could you test if it still works on python 2.3? > Is my technique sound? Mostly. I personally prefer having a global "fix", so that if the same method is used at several places, you don't have to duplicate part of the code and a try/except each time (because this reduce the code readability). I know having the try/except outside the method could be slightly less efficient as that particular piece of code might never be executed, but it's a tradeoff I'm ready to pay for increased code readability. Secondly, if you allow me a purely aesthetical remark: I very much like to respect PEP8 recommendations. So, please (try to) not use whitespace after an opening parenthesis, or before a closing one. > If I invest the time on addressing the compatibility issues with the > rest of the errors, can they be integrated as well? > > I guess what it really comes down to is what is the interest in > maintaining Python 2.3 compatibility? I'm very interested in your patches, tough I have to warn you that I don't have python 2.3 installed anymore on my computer these days, so I might accidentally break compatibility in future changes (I'll try not to but well, you know...). So, basically, it's up to you (or other people needing it) to warn me if I break compatibility before any release. Sorry if that sounds harsh, but I have to put limits to what I do. I hope you don't take it badly. Regards, -- Gaëtan de Menten http://openhex.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "SQLElixir" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlelixir?hl=en -~----------~----~----~----~------~----~------~--~---
