Hi, thanks for taking a look at my patch. Jonathan LaCour schrieb: > Johannes Janssen wrote: > > >> I propose a patch for resolve(), which makes to major changes: >> >> User defined resolve function >> > > I like this particular aspect of the patch, in theory. It allows for the > user to define the entity resolution process to their heart's content. > Btw. a user-defined resolve function should also get passed the EntityCollection, this not implemented in my patch. >> Resolving the module path >> > > I don't particularly like this idea. I think that the current approach > is simpler and more easy to understand. If we accept the patch for the > user-defined resolve function, you could (in theory) implement this > behavior in your own project if you wanted to. > Yeah I could live with that, but I don't think that the current solution is the best approach. That's of course just my own opinion and I don't what to force anyone to use my approach. We may discuss what is the best way to resolve path and what notation you want to use. My way of doing that is just one of many possible ones. I assume elixir's users want to split up their db definitions into submodules and elixir should support them to do this. Although it possible through full paths there are still the mentioned disadvantages. My patch is somewhat inspired by http://www.python.org/dev/peps/pep-0328/#guido-s-decision and therefore it's imho quite intuitive. >> For backwards compatibility you might give users the >> possibility to switch back manually to old behavior and give them a >> deprecation warning (for a few versions if there are to be more;)). >> > > This is another reason I dislike the second part of your patch. Okay if you don't want to break backwards compatibility you can keep the old resolve method and provide alternatives. But not being backwards compatible should imho not be a reason to hold back improvements.
Kind regards Johannes --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "SQLElixir" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sqlelixir?hl=en -~----------~----~----~----~------~----~------~--~---
