On Thu, Nov 19, 2009 at 10:28, Vinay Sajip <[email protected]> wrote: > Because SQLA's session.save has been removed in trunk, Elixir's > entity.save gives an error if run with newer versions of SQLA. Is it > worth modifying Entity.save to do session.add() if not hasattr > (session, 'save')?
I'm undecided on this issue... On one hand, I'd like to stay as close to SA as possible (otherwise people get confused if thing are named differently) and here the new SA name "add" doesn't sound good on a class, so I'm against adding it. For now, I've taken the stance that the methods stayed there for those using an old version of SA, but people using a recent version of SA should use the new paradigm: session.add(x). If enough people agree with you that save needs to be kept for the foreseeable future, then I'll fix it. In the meantime, you can use your own base class with whatever method you want on it, including a "fixed" save if you want. -- Gaëtan de Menten http://openhex.org -- You received this message because you are subscribed to the Google Groups "SQLElixir" group. To post to this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sqlelixir?hl=.
