I wouldn't count on the fact that it doesn't break any tests to say it's
not a bug; it still has the potential to break existing code. Perhaps it
could be done better as:
return $drop ? ($drop.$create) : $create;
Or even:
return "$drop$create";
Assuming $drop will be an empty string if not needed. Or using
wantarray:
return wantarray ? ($drop,$create) : "$drop$create";
Anyway, you get the idea.
Chris
> -----Original Message-----
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On
> Behalf Of Jess Robinson
> Sent: Tuesday, 14 November, 2006 03:17
> To: Darren Chamberlain
> Cc: [email protected]
> Subject: Re: [sqlfairy-developers] [sqlfairy-commits] CVS:
> sqlfairy/lib/SQL/Translator/Producer MySQL.pm, 1.50, 1.51
>
>
>
> On Thu, 9 Nov 2006, Darren Chamberlain wrote:
>
> > On 11/9/06, Jess Robinson
> <[EMAIL PROTECTED]> wrote:
> >> ***************
> >> *** 264,268 ****
> >> $create .= ";\n\n";
> >>
> >> ! return $create;
> >> }
> >>
> >> --- 266,270 ----
> >> $create .= ";\n\n";
> >>
> >> ! return $drop ? ($drop,$create) : $create;
> >> }
> >
> > This changes what comes back if create_table is called in
> non-scalar
> > context, which is a potential bug. Shouldn't the change
> account for
> > that?
> >
>
>
> Hi Darren,
>
> Not quite sure what you mean there? It should probably check
> wantarray there, true.. otherwise, my aim is in general to
> have all the producers return a list of statements in list
> context, and the usual scalar-with-everything otherwise..
> iirc this hasnt broken any existing tests.
>
> Jess
>
>
> --------------------------------------------------------------
> -----------
> Using Tomcat but need to do more? Need to support web
> services, security?
> Get stuff done quickly with pre-integrated technology to make
> your job easier Download IBM WebSphere Application Server
> v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&;
> dat=121642
> --
> sqlfairy-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers
>
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
sqlfairy-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers
