After hearing very good things about Hilmar's coding skills and not hearing back from anyone else about the patches, I applied them.
Thank you Hilmar. Ben On Thu, 2007-05-03 at 22:25 -0500, Ben Faga wrote: > Just wanted to let you know that I took a look at the patch and it looks > good. However, before I started testing, I realized that my install is > currently not working. > > So if anyone else could take a look at this (apply the patch and see if > it works), I would be more than happy to commit it. > > Ben > > On Mon, 2007-04-30 at 19:06 -0400, Hilmar Lapp wrote: > > The patches are attached. > > > > The changes really only affect the resulting diagram produced through > > graphviz. Hence, the test would need to run sqlt-graph and compare > > expected images with observed ones - which is notoriously hairy to do > > cross-platform. I didn't find any such test already in the package > > that would prove the actual correctness of an image or diagram, but > > maybe I've missed it? > > > > A nice thing you can do with this is for example --graphattr > > "rankdir=BT" which will render the graph bottom up, more along > > traditional ERDs (see http://tinyurl.com/3cyx4o as an example). > > > > Let me know if I can help any further. > > > > -hilmar > > > > On Apr 28, 2007, at 8:18 AM, Jess Robinson wrote: > > > > > > > > > > > > > > On Fri, 6 Apr 2007, Hilmar Lapp wrote: > > > > > >> Hi, > > >> > > >> when running sqlt-graph I got the ominous "Could not find/open font : > > >> Times-Roman" error from graphviz. > > >> > > >> Apparently on Mac OSX graphviz can't find the Times font unless you > > >> explicitly provide the full path as the fontname attribute (- > > >> Nfontname="/System/Library/Fonts/Times.dfont" when invoking dot, for > > >> example). (Also, this won't apply for ps output, obviously.) > > >> > > >> I noticed that there is no mechanism by which I can pass that through > > >> from sqlt-graph, and also I have no control over the node, edge, and > > >> graph attributes, so I went ahead and fixed all that. I have patches > > >> for bin/sqlt-graph and for S::T::P::GraphViz.pm. Do people want me to > > >> post these here to the mailing list or elsewhere, or do you want me > > >> to apply them directly? > > >> > > >> -hilmar > > >> -- > > >> =========================================================== > > >> : Hilmar Lapp -:- Durham, NC -:- hlapp at duke dot edu : > > >> =========================================================== > > >> > > > > > > Send the patches to the list please, including the relevant new > > > tests to prove they work. > > > > > > Jess > > > > > > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by DB2 Express > > Download DB2 Express C - the FREE version of DB2 express and take > > control of your XML. No limits. Just data. Click to get it now. > > http://sourceforge.net/powerbar/db2/ > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ -- sqlfairy-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers
