Hi,
Attached find the following:
* Fix POD incorrectly referring to argument show_sizes as show_col_sizes
* Fix POD formatting errors (=item instead of ==item)
* Fix and improve handling of the skip_fields argument (silence warning)
Cheers
Peter
Index: lib/SQL/Translator/Producer/GraphViz.pm
===================================================================
--- lib/SQL/Translator/Producer/GraphViz.pm (revision 1314)
+++ lib/SQL/Translator/Producer/GraphViz.pm (working copy)
@@ -38,7 +38,7 @@
add_color => 1,
show_constraints => 1,
show_datatypes => 1,
- show_col_sizes => 1
+ show_sizes => 1
}
) or die SQL::Translator->error;
@@ -93,22 +93,22 @@
custom font size for node and edge labels (note that arbitrarily large
sizes may be ignored due to page size or graph size constraints)
-==item * fontname
+=item * fontname
custom font name (or full path to font file) for node, edge, and graph
labels
-==item * nodeattrs
+=item * nodeattrs
reference to a hash of node attribute names and their values; these
may override general fontname or fontsize parameter
-==item * edgeattrs
+=item * edgeattrs
reference to a hash of edge attribute names and their values; these
may override general fontname or fontsize parameter
-==item * graphattrs
+=item * graphattrs
reference to a hash of graph attribute names and their values; these
may override the general fontname parameter
@@ -129,7 +129,7 @@
displayed next to each column's name; this option will have no
effect if the value of show_fields is set to false
-=item * show_col_sizes
+=item * show_sizes
if set to a true value, the size (in bytes) of each CHAR and
VARCHAR column will be displayed in parentheses next to the
@@ -260,8 +260,8 @@
my $show_sizes = $args->{'show_sizes'};
my $show_constraints = $args->{'show_constraints'};
my $join_pk_only = $args->{'join_pk_only'};
- my $skip_fields = $args->{'skip_fields'};
- my %skip = map { s/^\s+|\s+$//g; $_, 1 }
+ my $skip_fields = $args->{'skip_fields'} || '';
+ my %skip = map { s/^\s+|\s+$//g; length $_ ? ($_, 1) : () }
split ( /,/, $skip_fields );
$natural_join ||= $join_pk_only;
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
--
sqlfairy-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers
