On Wed, 14 Sep 2005, Jay Siegel wrote: >I'm on my second day of porting SQLite to an embedded >environment. I'm not sure if this is the appropriate >place to put these comments about the experience. >I've seen some type of "ticket" mechanism in CVS but I >don't know if these comments raise to the level of a >"bug", etc. > >Anyway, three things: > >1. There are many instances where (char *) to(unsigned >char *) implied casts are done (and vice versa). >These should really be fixed so fewer compiler >warnings are generated. Perhaps I'm the only one who >likes my builds to have no warnings...
Patches are always welcome, especially patches to make the build cleaner but which otherwise don't affect functionality, as these are generally easier to review. > >2. There is an implied availability of ctype, stdargs, >stdio, etc. All of these #includes and references to >the routines used within them should be moved to the >OS file. It is not always the case that these >routines are available and in fact, are not available >on my platform. SQLite is intended to be targeted at ANSI C based platforms. ctype.h, stdarg.h and stdio.h are all C89 files, and it is reasonable to expect these files are available. Where they are not, the platform is seriously deficient in what it provides, and in fact varargs are not even usable without stdarg.h. Would you expect SQLite to be viable if your platform were 8-bit? Probably not. So don't expect it to be viable without change if you haven't even got a reasonable ANSI C environment. Christian -- /"\ \ / ASCII RIBBON CAMPAIGN - AGAINST HTML MAIL X - AGAINST MS ATTACHMENTS / \