RE: [sqlite] CE locking -- review the code

[Robert Simpson]

> -----Original Message-----
> From: Isaac Raway [mailto:[EMAIL PROTECTED] 
>
> Upon a quick readthrough I noted that the filename is 
> concated into the 
> Mutex name as-is. This is potentially dangerous given that 
> Windows file 
> systems are not case sensitive and yet according to the CreateMutex 
> documentation "lpName [...] Name comparison is case sensitive. [...]" 
> This could lead to some unexpected behavior.

Good catch.

So starting at line 55:
  wcscpy(szName, L"sqlitel");
  wcscat(szName, pszFilename);
 +  CharLowerW(szName);

And while you're at it here's one other serious flaw I caught:

Line 49 change from:
  BOOL bInit = FALSE;
To:
  BOOL bInit = TRUE;

And then change line 78 from:
    bInit = TRUE;
To:
    bInit = FALSE;


I was initializing shared memory ONLY if it already existed.

Robert