I happily saw the changes to rtree.c v1.6 and have the following 
requested changes:

1) On a 64-bit machine, compilation generates two warnings:

sqlite3.c: In function ‘rtreeCreate’:
sqlite3.c:90889: warning: cast from pointer to integer of different size
sqlite3.c: In function ‘rtreeConnect’:
sqlite3.c:90902: warning: cast from pointer to integer of different size

(These lines refer to the casts on lines 614 and 623 of rtree.c)


2) In order to compile the rtree code into the amalgamated build (and 
thus not require a .load) with -DSQLITE_ENABLE_RTREE=1, please consider 
the following patch:

--- rtree.c     14 Jul 2008 15:37:01 -0000      1.6
+++ rtree.c     15 Jul 2008 19:01:44 -0000
@@ -59,6 +59,9 @@
  #ifndef SQLITE_CORE
    #include "sqlite3ext.h"
    SQLITE_EXTENSION_INIT1
+typedef sqlite3_int64 i64;
+typedef unsigned char u8;
+typedef unsigned int u32;
  #else
    #include "sqlite3.h"
  #endif
@@ -66,9 +69,6 @@
  #include <string.h>
  #include <assert.h>

-typedef sqlite3_int64 i64;
-typedef unsigned char u8;
-typedef unsigned int u32;

  typedef struct Rtree Rtree;
  typedef struct RtreeCursor RtreeCursor;

Steve Friedman

_______________________________________________
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Reply via email to