Pawel,

You should probably pull the current SQLite code and make sure the
patch even applies, and if not, check to make sure that the problem
hasn't already been fixed.  ext/fts3 should no longer have the flaw in
question, as that code was heavily rewritten.  Chromium's SQLite was
last synced from SQLite's version last September, and there has
continued to be SQLite development in the meanwhile.

The fts1/2 changes would probably be better recast in the mode of the
fts3 changes.  The relevant comment where things are coming clear was:
   http://code.google.com/p/chromium/issues/detail?id=15261#c20

-scott


On Wed, Aug 4, 2010 at 3:23 PM, Paweł Hajdan, Jr.
<phajdan...@chromium.org> wrote:
> I'm attaching a suggested patch to fix locale-unsafe usage of tolower in FTS
> code. The goal is to make Chromium closer to the upstream, so if you have a
> better solution, that's great.
>
> This is upstreaming a Chromium patch
> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/safe-tolower.patch?view=markup
>
> The issue has been reported, see
> http://www.sqlite.org/src/tktview/991789d9f3136a0460dc83a33e815c1aa9757c26
>
> What do you think?
>
> _______________________________________________
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>
>
_______________________________________________
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Reply via email to