> 
> If the underlying VFS does not support shared-memory (which the OS/2 VFS
> does not) then SQLite simply will not go into WAL mode.  No patching is
> needed for this.  Everything should work as delivered.
> 
> What exactly is malfunctioning?  What is the problem that this patch
> attempts to fix?
The mozilla bug was originally filed against 3.7.1. In pager.c was a
function: static int pagerPagecount in an #ifndef SQLITE_OMIT_WAL block.
The last 3 hunks of the original patch moved the exclusion of omit_wal
further down, because all sqlite databases in a new profile had zero
size on OS/2 and a warning was issued from firefox that history and
bookmarks won't work, because the data bases were in use by another program.
>> https://bugzilla.mozilla.org/attachment.cgi?id=474575
However, this issue has been fixed already in 3.7.2 [d1ed743b6e].
(Hopefully mozilla will update to 3.7.2 soon).

The rest of the patch contained (in fossil format) in
>>> https://bugzilla.mozilla.org/attachment.cgi?id=477692
is intended to explicitly disable WAL on OS/2
and bring the OS/2 related files up to date.
That involves:
- adding a new function, os2CurrentTimeInt64(), and refining the
  existing os2CurrentTime();
- adding new members to the "os2Vfs" structure, and explicitly
  defining them as NULL pointers since they support WAL;
- updating the OS/2 semaphore documentation to match other platforms.
It would be nice if these changes could be considered to get checked-in.
Thanks, Walter

_______________________________________________
sqlite-users mailing list
[email protected]
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Reply via email to