Hello,

Using (3.10.2), as was the case with 3.10.0, there are two warnings (VS.2015 at 
least, /W3 only) compiling in 64 bits:

sqldiff.c(997): warning C4244: 'return': conversion from '__int64' to 'int', 
possible loss of data
sqldiff.c(1144): warning C4244: 'return': conversion from '__int64' to 'int', 
possible loss of data

In both locations, changing:

    return zDelta - zOrigDelta;

to:

    return (int)(zDelta - zOrigDelta);

fixes it as the difference of two pointers is a 64 bits value while the 
function returns int.
There is nothing wrong at leaving it as is, it just would look better with the 
cast.

--
Meilleures salutations, Met vriendelijke groeten, Best Regards,
Olivier Mascia, integral.be/om

> Le 14 janv. 2016 ? 10:55, Olivier Mascia <om at integral.be> a ?crit :
> 
> Hello,
> 
> May I suggest to patch sqldiff.c (3.10.0) on lines 997 and 1144 as this:
> 
>    return (int)(zDelta - zOrigDelta);
> 
> instead of:
> 
>    return zDelta - zOrigDelta;
> 
> to suppress the benign warning about __int64 being converted to int which 
> some compilers can emit because the difference of two pointers is a 64 bits 
> value.
> 
> --
> Meilleures salutations, Met vriendelijke groeten, Best Regards,
> Olivier Mascia, integral.be/om
> 
> 
> _______________________________________________
> sqlite-users mailing list
> sqlite-users at mailinglists.sqlite.org
> http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: 
<http://mailinglists.sqlite.org/cgi-bin/mailman/private/sqlite-users/attachments/20160126/1f34142f/attachment.pgp>

Reply via email to