On 8/2/16, Andy Gibbs <andyg1...@hotmail.co.uk> wrote: > On Tuesday 02 Aug 2016 22:07:32 Andy wrote: >> Hi, >> >> I've attached a very small patch that eliminates a few "unused variable" >> warnings that occur when compiled with various OMIT_* options. >>
Thanks for the patch, Andy. It is appreciated. However, my current thinking is that we will not apply it. Here's why: (1) The patch only fixes a harmless warning. The code still works fine without the patch. (2) The warning only comes up when compiling with SQLITE_OMIT_AUTHORIZER, which is an obscure (and technically unsupported) compile-time option. (3) It is important to try to keep the amount of #ifdef-ery to a minimum. Some (many?) will argument that I'm already too late - that the amount of #ifdef-ery in SQLite is way out of control. But in any event, I want to try to keep it from getting unnecessarily worse. Please do not let this discourage you from making further suggestions in the future. -- D. Richard Hipp d...@sqlite.org _______________________________________________ sqlite-users mailing list sqlite-users@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
