Could someone with CVS access look into this for me.

I think there is a "documentation" error in SqliteInt.h

The routine sqlite3NestedParse in build.c shows that the variables up to
nVar are static

# define SAVE_SZ  (sizeof(Parse) - offsetof(Parse,nVar))

In addition analyze.c has the comments

       ** Note that a side-effect of the CREATE TABLE statement is to
leave
        ** the rootpage of the new table in register pParse.regRoot.
This is
        ** important because the OpenWrite opcode below will be needing
it. */


However in file sqliteInt.h the struc comments shows 

========================================================================
struct Parse {
...
<snip>
...
  int cookieValue[SQLITE_MAX_ATTACHED+2];  /* Values of cookies to
verify */
#ifndef SQLITE_OMIT_SHARED_CACHE
  int nTableLock;        /* Number of locks in aTableLock */
  TableLock *aTableLock; /* Required table locks for shared-cache mode
*/
#endif

  /* Above is constant between recursions.  Below is reset before and
after
  ** each recursion */

  int regRowid;        /* Register holding rowid of CREATE TABLE entry
*/
  int regRoot;         /* Register holding root page number for new
objects */
  int nVar;            /* Number of '?' variables seen in the SQL so far
*/

========================================================================

Shouldn't regRowid and regRoot be moved about the comment?

Thanks for checking,

Noah



CONFIDENTIALITY NOTICE: 
This message may contain confidential and/or privileged information. If you are 
not the addressee or authorized to receive this for the addressee, you must not 
use, copy, disclose, or take any action based on this message or any 
information herein. If you have received this message in error, please advise 
the sender immediately by reply e-mail and delete this message. Thank you for 
your cooperation.



_______________________________________________
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Reply via email to