On Wed, May 10, 2006 at 11:44:08AM -0600, Gabe Rudy wrote:
> Hey Oleg,
Hello.
> I encountered some annoying bugs in sqlobject-admin and figured I would pass
> on the patch that fixes them.
I have never used sqlobject-admin. Never even looked into it. :) I hope
Ian will look into the patch and decide what to do.
> Index: sqlobject/main.py
> - return '\n'.join(sql)
> + return sql
You touched main.py, and the change seems rather big - you made the
function to return a list instead of a string. For such a change I'd like
to see tests. Have you ran the test suite?
Oleg.
--
Oleg Broytmann http://phd.pp.ru/ [EMAIL PROTECTED]
Programmers don't die, they just GOSUB without RETURN.
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
sqlobject-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss
