----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1579/#review1533 -----------------------------------------------------------
Ship it! Look good to me. - Bilung On 2011-08-18 00:15:54, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1579/ > ----------------------------------------------------------- > > (Updated 2011-08-18 00:15:54) > > > Review request for Sqoop, jmhsieh and Bilung Lee. > > > Summary > ------- > > Modified OracleManager implementation to use global catalog views instead of > user-specific views for metadata queries. Also introduced a test case that > specifically exercises the functionality in question. Note that if this gets > committed, the Oracle test configuration would need to be changed in order to > introduce a new user that will be used by the OracleManagerTest. > > > This addresses bug SQOOP-317. > https://issues.apache.org/jira/browse/SQOOP-317 > > > Diffs > ----- > > /src/java/com/cloudera/sqoop/manager/OracleManager.java 1158963 > /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1158963 > /src/test/com/cloudera/sqoop/manager/OracleUtils.java 1158963 > > Diff: https://reviews.apache.org/r/1579/diff > > > Testing > ------- > > All unit and thirdparty tests along with some manual testing. > > > Thanks, > > Arvind > >
