[ 
https://issues.apache.org/jira/browse/SQOOP-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087364#comment-13087364
 ] 

[email protected] commented on SQOOP-317:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1579/#review1533
-----------------------------------------------------------

Ship it!


Look good to me.

- Bilung


On 2011-08-18 00:15:54, Arvind Prabhakar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1579/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-18 00:15:54)
bq.  
bq.  
bq.  Review request for Sqoop, jmhsieh and Bilung Lee.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Modified OracleManager implementation to use global catalog views instead 
of user-specific views for metadata queries. Also introduced a test case that 
specifically exercises the functionality in question. Note that if this gets 
committed, the Oracle test configuration would need to be changed in order to 
introduce a new user that will be used by the OracleManagerTest.
bq.  
bq.  
bq.  This addresses bug SQOOP-317.
bq.      https://issues.apache.org/jira/browse/SQOOP-317
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/java/com/cloudera/sqoop/manager/OracleManager.java 1158963 
bq.    /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1158963 
bq.    /src/test/com/cloudera/sqoop/manager/OracleUtils.java 1158963 
bq.  
bq.  Diff: https://reviews.apache.org/r/1579/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  All unit and thirdparty tests along with some manual testing.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Arvind
bq.  
bq.



> OracleManager should allow working with tables owned by other users.
> --------------------------------------------------------------------
>
>                 Key: SQOOP-317
>                 URL: https://issues.apache.org/jira/browse/SQOOP-317
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: 1.4.0
>
>         Attachments: SQOOP-317-1.diff, SQOOP-317.diff
>
>
> The default Oracle connector in Sqoop uses user-specific catalog views for 
> doing metadata lookup queires. This results in failure when the table is not 
> owned by the user that Sqoop connects as. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to