[
https://issues.apache.org/jira/browse/SQOOP-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089979#comment-13089979
]
[email protected] commented on SQOOP-321:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1623/#review1610
-----------------------------------------------------------
Changes look good Bilung. I do have a backward compatibility concern noted
below. Other than that, it will be good to give some examples of use of this
feature in the user guide. The more specific examples you can give, the better
it would be for the users.
src/java/com/cloudera/sqoop/manager/ConnManager.java
<https://reviews.apache.org/r/1623/#comment3639>
This may be a compatibility issue for third party connectors. It is best to
leave this method as is and introduce a new method that gets called when the
check column type is not numeric.
- Arvind
On 2011-08-22 23:20:55, Bilung Lee wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1623/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-22 23:20:55)
bq.
bq.
bq. Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently, when "--incremental append" option is used, only numeric
columns are supported for check column.
bq.
bq.
bq. This addresses bug SQOOP-321.
bq. https://issues.apache.org/jira/browse/SQOOP-321
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/com/cloudera/sqoop/manager/ConnManager.java cea0a73
bq. src/java/com/cloudera/sqoop/manager/OracleManager.java bad45dc
bq. src/java/com/cloudera/sqoop/tool/ImportTool.java 66e60bd
bq. src/test/com/cloudera/sqoop/TestIncrementalImport.java 96d4309
bq.
bq. Diff: https://reviews.apache.org/r/1623/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Bilung
bq.
bq.
> Support date/time columns for "--incremental append" option
> -----------------------------------------------------------
>
> Key: SQOOP-321
> URL: https://issues.apache.org/jira/browse/SQOOP-321
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Bilung Lee
> Assignee: Bilung Lee
>
> Currently, when "--incremental append" option is used, only numeric columns
> are supported for check column.
> One workaround to "mimic" append mode with date/time values is
> 1) select max(dt) from table into max_dt
> 2) sqoop import --incremental lastmodified --check-column dt --last-value
> max_dt
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
