File a JIRA and assign it to me. I'll ready a patch for review tomorrow. -Joey
On Thu, Sep 15, 2011 at 5:07 PM, Joseph Boyd <[email protected]> wrote: > Anyone else interested in this? As such an easy fix, I'd hate to see > it just sit, abandoned in a JIRA for months. > > ...joe > > > On Tue, Sep 13, 2011 at 3:47 PM, Ken Krugler > <[email protected]> wrote: >> >> On Sep 13, 2011, at 3:20pm, Joseph Boyd wrote: >> >>> Hi all, >>> >>> NamedFifo makes a system call to 'mknod' that isn't compatible with >>> the version of mknod installed on my mac. >>> >>> I think, though, that it could be replaced easily enough with a call >>> to 'mkfifo' which would be compatible with both my mac and with the >>> Linux servers people typically develop for. >>> >>> This change to NamedFifo seems to be all that's needed : >>> >>> - Shell.execCommand("mknod", "--mode=0" + modeStr, filename, "p"); >>> + Shell.execCommand("mkfifo", "-m", "0" + modeStr, filename ); >>> >>> >>> I haven't done any extensive testing of this, nor have I dug much into >>> details of what options to mknod / mkfifo are standard/common. >>> >>> I just wanted the test suite to pass on my macbook. ;) >>> >>> >>> Any comments here? >> >> Yes - thanks for reminding me, I wound up making the same mod a few months >> back, and had hidden it in my patch for SQOOP-175. >> >> < Shell.execCommand("mknod", "--mode=0" + modeStr, filename, "p"); >> --- >>> Shell.execCommand("mkfifo", "-m", "0" + modeStr, filename); >> >> Looks very similar :) >> >> We've been using code with this mod extensively on Macs and Redhat >> Enterprise 5.3, so it's been tested in those environments. >> >> -- Ken >> >> -------------------------- >> Ken Krugler >> +1 530-210-6378 >> http://bixolabs.com >> custom big data solutions & training >> Hadoop, Cascading, Mahout & Solr >> >> >> >> > -- Joseph Echeverria Cloudera, Inc. 443.305.9434
