[
https://issues.apache.org/jira/browse/SQOOP-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109142#comment-13109142
]
[email protected] commented on SQOOP-329:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1983/#review1989
-----------------------------------------------------------
Thanks for the patch! One thing though. Those catalog queries (except for the
current timestamp one) are specific to DB2 LUW and thus they may not work for
other platforms (like zOS) of DB2.
/src/java/com/cloudera/sqoop/manager/Db2Manager.java
<https://reviews.apache.org/r/1983/#comment4481>
So you may want to consider not to inherit from CatalogQueryManager. For
listDatabases(), you could use DatabaseMetaData.getSchemas() for cross-platform
support. For listTables(), getColumnNames(), and getPrimaryKey(), parent
methods in SqlManager would be supported across platforms since they use
generic JDBC metadata APIs.
- Bilung
On 2011-09-20 17:30:46, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1983/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-20 17:30:46)
bq.
bq.
bq. Review request for Sqoop and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added Db2Manager implementation along with a simple import test that is
currently categorized as manual test.
bq.
bq.
bq. This addresses bug SQOOP-329.
bq. https://issues.apache.org/jira/browse/SQOOP-329
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /COMPILING.txt 1172789
bq. /src/java/com/cloudera/sqoop/manager/Db2Manager.java PRE-CREATION
bq. /src/java/com/cloudera/sqoop/manager/DefaultManagerFactory.java 1172789
bq. /src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/1983/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran all the unit, thirdparty, and manual tests. Checkstyle/findbugs did
not introduce new warnings.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> SQOOP doesn't work with the DB2 JCC driver
> ------------------------------------------
>
> Key: SQOOP-329
> URL: https://issues.apache.org/jira/browse/SQOOP-329
> Project: Sqoop
> Issue Type: Bug
> Reporter: Brock Noland
> Assignee: Arvind Prabhakar
> Attachments: SQOOP-329.patch
>
>
> SQOOP doesn't work with the DB2 JCC driver. I needed to write some code.
> Just need to override these two methods:
> getDriverClass --> "com.ibm.db2.jcc.DB2Driver"
> getCurTimestampQuery --> Return "SELECT CURRENT TIMESTAMP FROM
> sysibm.sysdummy1 WITH UR;"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
