[
https://issues.apache.org/jira/browse/SQOOP-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140323#comment-13140323
]
[email protected] commented on SQOOP-375:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2612/#review2950
-----------------------------------------------------------
Thanks for your contribution, Jarcec! Some comments below.
/src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java
<https://reviews.apache.org/r/2612/#comment6594>
Remove trailing space.
/src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java
<https://reviews.apache.org/r/2612/#comment6605>
Remove the non-static method in subclass.
/src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
<https://reviews.apache.org/r/2612/#comment6596>
Remove trailing space.
/src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
<https://reviews.apache.org/r/2612/#comment6604>
Should inherit from "org.apache.sqoop.metastore.hsqldb.AutoHsqldbStorage".
/src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
<https://reviews.apache.org/r/2612/#comment6603>
Remove this constant, which is private and is not needed.
/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java
<https://reviews.apache.org/r/2612/#comment6606>
Change to "com.cloudera.sqoop.metastore.JobStorage". I.e. should inherit
from this for backward compatibility.
- Bilung
On 2011-10-29 14:04:59, Jarek Jarcec wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2612/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-29 14:04:59)
bq.
bq.
bq. Review request for Sqoop and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've migrated the metastore packages.
bq.
bq.
bq. This addresses bug SQOOP-375.
bq. https://issues.apache.org/jira/browse/SQOOP-375
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/com/cloudera/sqoop/metastore/JobData.java 1190770
bq. /src/java/com/cloudera/sqoop/metastore/JobStorage.java 1190770
bq. /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java 1190770
bq. /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
1190770
bq. /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java
1190770
bq. /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java
1190770
bq. /src/java/org/apache/sqoop/metastore/JobData.java PRE-CREATION
bq. /src/java/org/apache/sqoop/metastore/JobStorage.java PRE-CREATION
bq. /src/java/org/apache/sqoop/metastore/JobStorageFactory.java PRE-CREATION
bq. /src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2612/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Migrate metastore and metastore.hsqldb packages to new name space
> -----------------------------------------------------------------
>
> Key: SQOOP-375
> URL: https://issues.apache.org/jira/browse/SQOOP-375
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Bilung Lee
> Assignee: Jarek Jarcec Cecho
>
> Refer to SQOOP-371 for details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
