[
https://issues.apache.org/jira/browse/SQOOP-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155382#comment-13155382
]
[email protected] commented on SQOOP-362:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2883/#review3442
-----------------------------------------------------------
Ship it!
Overall the changes look good, with one comment below. Please attach the patch
to the JIRA when done.
/src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java
<https://reviews.apache.org/r/2883/#comment7685>
This should be INTEGER instead.
- Arvind
On 2011-11-19 20:08:03, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2883/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-19 20:08:03)
bq.
bq.
bq. Review request for Sqoop and Arvind Prabhakar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've finished user mapping by allowing redefine output for avro as well.
bq.
bq.
bq. This addresses bug SQOOP-362.
bq. https://issues.apache.org/jira/browse/SQOOP-362
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/com/cloudera/sqoop/SqoopOptions.java 1203816
bq. /src/java/org/apache/sqoop/SqoopOptions.java 1203816
bq. /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java 1203816
bq. /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1203816
bq. /src/java/org/apache/sqoop/tool/ImportTool.java 1203816
bq. /src/test/com/cloudera/sqoop/TestAvroImport.java 1203816
bq.
bq. Diff: https://reviews.apache.org/r/2883/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * Added new test for mapping override
bq. * Passed standard tests
bq. * Passed check style
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Allow user to override mapping when doing import to AVRO format
> ---------------------------------------------------------------
>
> Key: SQOOP-362
> URL: https://issues.apache.org/jira/browse/SQOOP-362
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
>
> We should allow user to override default mapping even for AVRO file format.
> This is follow up issue for issue SQOOP-342.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
