----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3126/ -----------------------------------------------------------
(Updated 2011-12-12 19:31:05.321849) Review request for Sqoop and Jarek Cecho. Changes ------- This only contains a static method on ConfigurationHelper to provide functionality for getInstances(), along with a couple of changes in code to use it. Summary ------- I added a ConfigurationHolder class, to try and make sqoop more compatible with hadoop 0.20.x. This addresses bug https://issues.apache.org/jira/browse/SQOOP-384. https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-384 Diffs (updated) ----- /src/java/org/apache/sqoop/config/ConfigurationHelper.java 1213348 /src/java/org/apache/sqoop/metastore/JobStorageFactory.java 1213348 /src/java/org/apache/sqoop/tool/SqoopTool.java 1213348 Diff: https://reviews.apache.org/r/3126/diff Testing ------- "ant test" passes. I haven't had much success running sqoop at all, due to the bug this patch is trying to fix (SQOOP-384). Thanks, Eric
