[
https://issues.apache.org/jira/browse/SQOOP-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173727#comment-13173727
]
[email protected] commented on SQOOP-412:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3272/#review4028
-----------------------------------------------------------
Ship it!
+1
Thanks for the patch Jarcec. The changes look good. I tested basic import
against MySQL and Hadoop 0.20.205 and that seems to work.
Please attach the patch to the JIRA and also update the "Bugs" field to
SQOOP-413 as that is the relevant JIRA for this issue.
- Arvind
On 2011-12-20 17:09:54, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3272/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-20 17:09:54)
bq.
bq.
bq. Review request for Sqoop and Arvind Prabhakar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've copypasted all four files from CHD3 release and put them into sqoop
mapreduce module (I altered files to conform our checkstyle policy). I've also
changed all references in sqoop to use this new for classes instead of the
default ones present in hadoop-0.21.
bq.
bq.
bq. This addresses bug SQOOP-412.
bq. https://issues.apache.org/jira/browse/SQOOP-412
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/com/cloudera/sqoop/mapreduce/CombineShimRecordReader.java
1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java
1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java
1221303
bq.
/src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java
1221303
bq.
/src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java
1221303
bq. /src/java/org/apache/sqoop/config/ConfigurationHelper.java 1221303
bq. /src/java/org/apache/sqoop/lib/SqoopRecord.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/CombineFileInputFormat.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/CombineFileRecordReader.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/CombineFileSplit.java PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/CombineShimRecordReader.java
1221303
bq. /src/java/org/apache/sqoop/mapreduce/DBWritable.java PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/ExportInputFormat.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/MySQLDumpImportJob.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/MySQLExportJob.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java
1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java
1221303
bq.
/src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java
1221303
bq.
/src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java
1221303
bq.
/src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java
1221303
bq.
bq. Diff: https://reviews.apache.org/r/3272/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I've tested with both -Dhadopoversion=20 and -Dhadoopversion=23.
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Create our own implementation of
> org.apache.hadoop.conf.Configuration.getInstances
> ----------------------------------------------------------------------------------
>
> Key: SQOOP-412
> URL: https://issues.apache.org/jira/browse/SQOOP-412
> Project: Sqoop
> Issue Type: Sub-task
> Components: codegen
> Affects Versions: 1.3.0, 1.4.0-incubating
> Reporter: Jarek Jarcec Cecho
> Assignee: Eric Wadsworth
> Priority: Minor
> Labels: patch
> Fix For: 1.4.1-incubating
>
> Attachments: try_6_ConfigurationHelper_getInstances.patch
>
>
> We need to port functionality of
> org.apache.hadoop.conf.Configuration.getInstances for supporting hadoop
> releases before 0.21 (or before CDH3).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
