[
https://issues.apache.org/jira/browse/SQOOP-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174334#comment-13174334
]
[email protected] commented on SQOOP-413:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3272/#review4054
-----------------------------------------------------------
Ship it!
+1
Did more sanity testing. All looks good.
- Arvind
On 2011-12-21 06:26:13, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3272/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-21 06:26:13)
bq.
bq.
bq. Review request for Sqoop and Arvind Prabhakar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've copypasted all four files from CHD3 release and put them into sqoop
mapreduce module (I altered files to conform our checkstyle policy). I've also
changed all references in sqoop to use this new four classes instead of the
default ones present in hadoop-0.21.
bq.
bq.
bq. This addresses bug SQOOP-413.
bq. https://issues.apache.org/jira/browse/SQOOP-413
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/com/cloudera/sqoop/mapreduce/CombineShimRecordReader.java
1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java
1221303
bq. /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java
1221303
bq.
/src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java
1221303
bq.
/src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java
1221303
bq. /src/java/org/apache/sqoop/config/ConfigurationHelper.java 1221303
bq. /src/java/org/apache/sqoop/lib/SqoopRecord.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/CombineFileInputFormat.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/CombineFileRecordReader.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/CombineFileSplit.java PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/CombineShimRecordReader.java
1221303
bq. /src/java/org/apache/sqoop/mapreduce/DBWritable.java PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/ExportInputFormat.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/MySQLDumpImportJob.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/MySQLExportJob.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java
1221303
bq. /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java
1221303
bq.
/src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java
1221303
bq.
/src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java
1221303
bq.
/src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java
1221303
bq.
bq. Diff: https://reviews.apache.org/r/3272/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I've tested with both -Dhadopoversion=20 and -Dhadoopversion=23.
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Port files org.apache.hadoop.mapreduce.lib.{db,input}.* from CDH3/Hadoop-0.21
> to sqoop
> --------------------------------------------------------------------------------------
>
> Key: SQOOP-413
> URL: https://issues.apache.org/jira/browse/SQOOP-413
> Project: Sqoop
> Issue Type: Sub-task
> Components: codegen
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.4.1-incubating
>
> Attachments: SQOOP-413.patch
>
>
> We need to port following files from hadoop-0.21 (or CDH3) to sqoop to
> support hadoop-0.20 that is still in use:
> org.apache.hadoop.mapreduce.lib.db.DBWritable
> org.apache.hadoop.mapreduce.lib.input.CombineFileSplit
> org.apache.hadoop.mapreduce.lib.input.CombineFileInputFormat
> org.apache.hadoop.mapreduce.lib.input.CombineFileRecordReader
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
