[
https://issues.apache.org/jira/browse/SQOOP-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174360#comment-13174360
]
Jarek Jarcec Cecho commented on SQOOP-411:
------------------------------------------
Hi Lars,
thank you very much for your time. I've looked on your patch and I believe that
problem might be caused by extra lines above the patch itself (first 10 lines
seems as an email fragment to me).
I've noticed that you've removed the explicit module paths on various places in
the code (for example you've changed com.cloudera.sqoop.lib.DelimiterSet to
DelimiterSet). I know that it's very confusing at the moment, but the reason
behind having the explicit full path is to be binary compatible with versions
before 1.4.0, so I need to ask you to put full paths back.
Other than that your patch seems very nice and I would like to see it
committed. Might I ask you to fix this two small nits and upload it to review
board for review process?
Jarcec
> Precompile Pattern for replacement of Hive delimiters
> -----------------------------------------------------
>
> Key: SQOOP-411
> URL: https://issues.apache.org/jira/browse/SQOOP-411
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Lars Francke
> Priority: Minor
> Attachments: SQOOP-411.1.patch
>
>
> The method {{FieldFormatter.hiveStringReplaceDelims}} is potentially called
> millions of times so precompiling the replacement pattern makes sense.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
