----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3357/#review4179 -----------------------------------------------------------
Ship it! Hi Lars, thank you very much for your time on this issue. Patch looks good. I've noticed that you've already uploaded it to JIRA, so I'll commit it shortly. Jarcec - Jarek On 2012-01-03 16:00:41, Lars Francke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3357/ > ----------------------------------------------------------- > > (Updated 2012-01-03 16:00:41) > > > Review request for Sqoop. > > > Summary > ------- > > Introduces a precompiled Pattern for the Hive delimiter chars > > > This addresses bug SQOOP-411. > https://issues.apache.org/jira/browse/SQOOP-411 > > > Diffs > ----- > > /src/java/org/apache/sqoop/lib/FieldFormatter.java 1226835 > > Diff: https://reviews.apache.org/r/3357/diff > > > Testing > ------- > > All tests succeed > > > Thanks, > > Lars > >
