[
https://issues.apache.org/jira/browse/SQOOP-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188131#comment-13188131
]
[email protected] commented on SQOOP-409:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3506/#review4431
-----------------------------------------------------------
Ship it!
- Bilung
On 2012-01-17 18:59:07, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3506/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-17 18:59:07)
bq.
bq.
bq. Review request for Sqoop, Arvind Prabhakar, Alex Newman, and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've tweaked parameter handling to rise an exception in case that both
--direct and --hive-drop-import-delims are present on the command line.
bq.
bq.
bq. This addresses bug SQOOP-409.
bq. https://issues.apache.org/jira/browse/SQOOP-409
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/org/apache/sqoop/tool/ImportTool.java 1231506
bq.
bq. Diff: https://reviews.apache.org/r/3506/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> hive-drop-import-delims doesn't work with MySQL direct import
> -------------------------------------------------------------
>
> Key: SQOOP-409
> URL: https://issues.apache.org/jira/browse/SQOOP-409
> Project: Sqoop
> Issue Type: Bug
> Components: hive-integration
> Affects Versions: 1.4.0-incubating
> Reporter: Lars Francke
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.4.1-incubating
>
> Attachments: SQOOP-409.patch, SQOOP-409.patch
>
>
> When using {{hive-drop-import-delims}} together with {{direct}} on a MySQL
> database the delimiters are not dropped. I have not tested PostgreSQL yet.
> I tried looking at the code but it wasn't easy to follow.
> There seem to be at least two problems:
> * The logic in {{MySQLDumpMapper.map}} only looks for
> {{MySQLUtils.outputDelimsAreMySQL(conf)}} to decide if it needs to be
> reparsed or not, this should also include the hive options
> * This is just a guess at the real problem: The {{ReparsingStreamThread}}
> calls a {{RecordParser}} directly without using the created ORM classes and
> thus circumventing the calls to {{hiveStringDropDelims}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
