-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3581/
-----------------------------------------------------------
(Updated 2012-01-25 20:43:00.432171)
Review request for Sqoop and Bilung Lee.
Changes
-------
I've incorporated both changes - I've added comment with full explanation and
put space after 'if' statement.
Summary
-------
I've just tweak code generation to support use case mentioned in the JIRA -
case when both keyword and _keyword columns are present in the same table.
Current code generation code might create many other duplicates because of
dropping of unsupported characters and other transformations. Those advanced
problems might be solved by --query and SQL projections ('column!' AS column2,
'column?' as column3).
This addresses bug SQOOP-430.
https://issues.apache.org/jira/browse/SQOOP-430
Diffs (updated)
-----
/src/java/org/apache/sqoop/orm/ClassWriter.java 1235863
/src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1235863
Diff: https://reviews.apache.org/r/3581/diff
Testing
-------
All tests pass for both hadoopversion=20 and hadoopversion=23.
Thanks,
Jarek
