[ 
https://issues.apache.org/jira/browse/SQOOP-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193390#comment-13193390
 ] 

[email protected] commented on SQOOP-430:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3581/
-----------------------------------------------------------

(Updated 2012-01-25 22:01:34.593867)


Review request for Sqoop and Bilung Lee.


Changes
-------

I've fixed my explanation comment to fulfill check style policy.


Summary
-------

I've just tweak code generation to support use case mentioned in the JIRA - 
case when both keyword and _keyword columns are present in the same table. 
Current code generation code might create many other duplicates because of 
dropping  of unsupported characters and other transformations. Those advanced 
problems might be solved by --query and SQL projections ('column!' AS column2, 
'column?' as column3).


This addresses bug SQOOP-430.
    https://issues.apache.org/jira/browse/SQOOP-430


Diffs (updated)
-----

  /src/java/org/apache/sqoop/orm/ClassWriter.java 1235863 
  /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1235863 

Diff: https://reviews.apache.org/r/3581/diff


Testing
-------

All tests pass for both hadoopversion=20 and hadoopversion=23.


Thanks,

Jarek


                
> Duplicate Column problem with reserved words
> --------------------------------------------
>
>                 Key: SQOOP-430
>                 URL: https://issues.apache.org/jira/browse/SQOOP-430
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.0-incubating
>            Reporter: Lars Francke
>            Assignee: Jarek Jarcec Cecho
>            Priority: Minor
>             Fix For: 1.4.1-incubating
>
>         Attachments: SQOOP-430.patch, SQOOP-430.patch
>
>
> This is a constructed example but given a table with two columns: {{class}} 
> and {{_class}} we get an error message upon running Sqoop:
> {quote}Imported Failed: Duplicate Column identifier specified: '_class{quote}
> This happens because the {{ClassWriter}} rewrites all columns that are 
> reserved keywords in Java by prepending a "_".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to