[
https://issues.apache.org/jira/browse/SQOOP-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194371#comment-13194371
] [email protected] commented on SQOOP-432: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3645/#review4642 ----------------------------------------------------------- Ship it! - Bilung On 2012-01-26 22:01:20, Joseph Boyd wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3645/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-01-26 22:01:20) bq. bq. bq. Review request for Bilung Lee and Jarek Cecho. bq. bq. bq. Summary bq. ------- bq. bq. Patch for SQOOP-432 bq. bq. https://issues.apache.org/jira/browse/SQOOP-432 bq. bq. bq. This addresses bug SQOOP-432. bq. https://issues.apache.org/jira/browse/SQOOP-432 bq. bq. bq. Diffs bq. ----- bq. bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/cli/SqoopParser.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/hive/TableDefWriter.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/orm/ClassWriter.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ImportTool.java 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/test/checkstyle.xml 1236344 bq. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAvroImport.java 1236344 bq. bq. Diff: https://reviews.apache.org/r/3645/diff bq. bq. bq. Testing bq. ------- bq. bq. 'ant checkstyle' returns no errors after the changes in the patch. bq. bq. bq. Thanks, bq. bq. Joseph bq. bq. > Enforce writing space after if statement > ---------------------------------------- > > Key: SQOOP-432 > URL: https://issues.apache.org/jira/browse/SQOOP-432 > Project: Sqoop > Issue Type: Improvement > Affects Versions: 1.3.0, 1.4.0-incubating > Reporter: Jarek Jarcec Cecho > Assignee: Joseph Boyd > Priority: Minor > Attachments: SQOOP-432.patch > > > We're currently not enforcing (=~ "ant checkstyle" is not enforcing) writing > space after if statement even though we're using such code policy in the > code. Would be nice if the policy would be enforced to be consistent across > entire code base. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
