[
https://issues.apache.org/jira/browse/SQOOP-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219869#comment-13219869
]
[email protected] commented on SQOOP-450:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4121/#review5491
-----------------------------------------------------------
Ship it!
Looks good! Thanks Arvind.
- Kate
On 2012-03-01 04:39:42, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4121/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-01 04:39:42)
bq.
bq.
bq. Review request for Sqoop.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See Jira description for problem summary. The fix was to add the logic in
the mapper sinks to parse out and ignore empty lines and those that begin with
a comment marker.
bq.
bq.
bq. This addresses bug SQOOP-450.
bq. https://issues.apache.org/jira/browse/SQOOP-450
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1295369
bq.
bq. Diff: https://reviews.apache.org/r/4121/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran DirectMySQLTest and MySQLAuthTest using mysqldump version 5.5.19 going
against server version 5.1.61 where this problem is reproducible. Also tested
against a system with MySQL version 5.5.20 where this problem was originally
not reproducible.
bq.
bq. Apart from this, ran the customary unit tests and third party tests.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> Direct MySQL import can fail when using mysqldump version 5.1.14 or above.
> --------------------------------------------------------------------------
>
> Key: SQOOP-450
> URL: https://issues.apache.org/jira/browse/SQOOP-450
> Project: Sqoop
> Issue Type: Bug
> Components: connectors/mysql
> Affects Versions: 1.4.1-incubating
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Attachments: SQOOP-450-1.patch
>
>
> When using direct MySQL connector, the expected output of the {{mysqldump}}
> command is individual records as follows:
> {noformat}
> INSERT INTO `EMPLOYEES_MYSQL_1` VALUES (2,'Bob',100,'2009-04-20',400,'sales');
> INSERT INTO `EMPLOYEES_MYSQL_1` VALUES
> (3,'Fred',4000000000,'2009-01-23',15,'marketing');
> {noformat}
> However, if the client version of MySQL being used is 5.1.14 or above, the
> output may have a warning header as follows if the tablespaces are not
> defined:
> {noformat}
> --
> -- Not dumping tablespaces as no INFORMATION_SCHEMA.FILES table on this server
> --
> INSERT INTO `EMPLOYEES_MYSQL_1` VALUES (2,'Bob',100,'2009-04-20',400,'sales');
> INSERT INTO `EMPLOYEES_MYSQL_1` VALUES
> (3,'Fred',4000000000,'2009-01-23',15,'marketing');
> {noformat}
> Notice that it contains an empty line and other lines that begin with the
> comment marker {{\-\-}}.
> This causes the MySQLDumpMapper to error out due to unexpected format of the
> records being read.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
