-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4172/
-----------------------------------------------------------
Review request for Sqoop and Bilung Lee.
Summary
-------
Oracle compatibility tests are fragile since the output format of timestamp
from the DB varies depending on versions. To test different versions
effectively, we should make the output more deterministic.
The changes include:
1) Add format mask to the select query.
2) Update OracleCompatTest accordingly.
Note that date and timestamp are not distinguishable by the Oracle JDBC driver,
so the same format is applied to date output as timestamp. Therefore, the
testDate methods in OracleCompatTest expect timestamp output.
This addresses bug SQOOP-451.
https://issues.apache.org/jira/browse/SQOOP-451
Diffs
-----
./src/java/org/apache/sqoop/manager/OracleManager.java 1296761
./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1296761
Diff: https://reviews.apache.org/r/4172/diff
Testing
-------
ant test
ant test -Dthirdparty=true
Thanks,
Cheolsoo
