----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4287/#review5833 -----------------------------------------------------------
Thanks for the patch Kathleen. Changes look good, one minor suggestion below for you to consider: ./src/docs/user/troubleshooting.txt <https://reviews.apache.org/r/4287/#comment12735> The error is more of a SQL syntax error instead of a connection error. I suggest that you modify the title to: Oracle: ORA-00933 error (SQL command not properly ended) - Arvind On 2012-03-11 17:14:43, Kathleen Ting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4287/ > ----------------------------------------------------------- > > (Updated 2012-03-11 17:14:43) > > > Review request for Sqoop and Arvind Prabhakar. > > > Summary > ------- > > Updated Documentation. > > > This addresses bug SQOOP-461. > https://issues.apache.org/jira/browse/SQOOP-461 > > > Diffs > ----- > > ./src/docs/user/troubleshooting.txt 1299394 > > Diff: https://reviews.apache.org/r/4287/diff > > > Testing > ------- > > Built docs and verified. > > > Thanks, > > Kathleen > >
