paul- wrote: > AFAIK that was the patch that was inplace for along time, we just > updated to the latest flac source, and the patch needed rebased against > the newer versions of flac. But it seems to make sense to me to patch > flac for this issue. The patch approach means it is easier to keep in step with official releases of the flac utility.
> I've been sort of following this thread, is there definitive pass/fail > test for this? I'd like to know if other OS's are affected. For pCP, > we don't typically run the OS with locale support loaded...... LANG=C I think mrw and rheinholdk have ccreated test. For PCP try mrw's https://forums.slimdevices.com/showthread.php?110871-Playing-cue-files-with-LMS&p=948338&viewfull=1#post948338 I think it should be possible to create a simple standalone shell script and windows bat to show how same command line can fail/succeed depending on locale settings. It will then also be a test for a fix. The flac utility uses strtod which uses locale setting. There is a strtod_l which support a locale parameters - so if code was changed to use strtod_l and a "C" locale - this make time parsing be locale independent. ------------------------------------------------------------------------ bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806 View this thread: http://forums.slimdevices.com/showthread.php?t=110871 _______________________________________________ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/squeezecenter
