On Tue, 17 May 2005, Beamish-White, James, VF-NZ wrote:
Attached is the patch (generated from diff -Naur).
The main changes are made in HttpHeaderTools.c, but the error I am getting is:
helperHandleRead: unexpected read from header_rewriter #1, 161 bytes
...which is debug in the helper.c file.
This indicates there was data received from the helper when none were expected. May be related to the problem below...
there's an error when it does work, and if I also include the redirect_program directive in the squid.conf (a requirement), it hangs without response.
this looks to be due to the following change in helper.c which unintentionally breaks the normal style helpers, and probably is unreliable for the header style helpers..
+ } else if ((hlp->double_cr_end && (t = strchr(srv->buf, '\n'))) || + (hlp->double_cr_end && (t = strstr(srv->buf, "\r\n\r\n"))) + ) { /* end of reply found */ + debug(84, 3) ("helperHandleRead: end of reply found\n"); + if( strstr(srv->buf, "\r\n\r\n") )
The first condition needs to be negated (if NOT double_cr_end ...)
} else if ((!hlp->double_cr_end && (t = strchr(srv->buf, '\n'))) ||
^^^
Regards Henrik
