On Wed, 25 May 2005, Rafael Martinez Torres wrote:

Index: ACLIP.cc
-        if (ntohl(A.s_addr) > ntohl(C.s_addr))
+        if (memcmp(&A, &C, sizeof(struct IN_ADDR)) >0)

Hmm.. this has quite different semantics. The original looks at the addresses in host byte order, while the memcmp looks at the addresses in network byte order...

are you sure this change is OK here?

Regards
Henrik

Reply via email to