On Tue, 9 Aug 2005, Serassio Guido wrote:
Sure. I have used 'eol' only to have a very small change in tools.c:
- snprintf(command, 256, "mail %s < %s", Config.adminEmail, filename);
+ snprintf(command, 256, "%s %s < %s", Config.EmailProgram,
Config.adminEmail, filename);
Right.. eol is better/simpler here ;)
I think that something like the following configuration tags could be very
useful:
- The destination e-mail address (today we have only this)
- The from e-mail address, currently we use appname string
- The subject of the message
- The email program to use
- The email program command line with % codes that can be expanded with to,
from and subject values
- The message body itself, with again % codes that can be expanded with a
error code/message and the to, from and subject values
But probably a similar change is too big for 2.5.
Agreed. Something to think about for Squid-3.
If you like, I could write a simplified version for 2.5, with only the
following tags:
mail_program a string with the mail program name
mail_program_options a wordlist with mail program command line options
No, I think the existing patch is fine. Didn't know we executed mail in
such simpleminded manner.
Regards
Henrik
