On Thu, 2008-09-11 at 13:33 +1200, Amos Jeffries wrote: > > On Thu, 2008-09-11 at 03:55 +1200, Amos Jeffries wrote: > >> This update removes several magic number options in the WCCPv2 > >> configuration. Replacing them with user-freindly text options. > > > >> This should help with a lot of config confusion where these are needed > >> until they are obsoleted properly. > > > > It looks like the changes affect a lot more than WCCPv2 options though. > > Some ACL defaults are changed (at least in the definition, not sure > > about internals). ICP port 7 comment is removed. Etc. > > > > Can those WCCP-unrelated changes be briefly described? > > Sorry, built the bundle wrong. Dragged in some pending changes from the > minimal squid.conf submission last week (its done in the same branch > here). > > What I intended to commit was the parser and change to allow: > wccp2_return_method gre_hash > wccp2_forwarding_method gre_hash > wccp2_assignment_method l2_mask > > instead of: > wccp2_return_method 1 > wccp2_forwarding_method 1 > wccp2_assignment_method 2
Sounds like the right thing to do. Please commit if you have no doubts. Thank you, Alex.
