fre 2009-06-26 klockan 11:05 -0600 skrev Alex Rousskov:
> On 06/16/2009 09:57 PM, Mark Nottingham wrote:
> > Thanks. Anybody else have a second to look?
> 
> Please s/fwdStartFoo/fwdContinue/ and document what it is. Since this is
> Squid2 you do not have to do it, of course.
> 
> Your cbdata and request manipulations appear technically correct to me.
> IMHO, the temporary lack of requestLink is poor style that will be
> dangerous for future code modifications.

Agreed on all points.

In addition i would like the internal & cacheobj checks to be moved up
before miss_access, but that is a separate change.

Regards
Henrik

Reply via email to